From dae5ad67d9d6a5c6ff188f7ed76d7c8fd7a960c9 Mon Sep 17 00:00:00 2001 From: Vincent De Smet Date: Mon, 20 Feb 2017 17:53:03 +0800 Subject: [PATCH] Update Dockerfile to Best Practices: - Version pinning on Base Image - COPY is preferred over ADD - apk -U will leave index in image, use `--no-cache` to avoid storing repo index - curl kubectl directly to final destination - Change entrypoint instead of running `sh -c bash -c /bin/update.sh` --- Dockerfile | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/Dockerfile b/Dockerfile index 76a40a6..a9344bb 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,8 +1,7 @@ -FROM alpine -RUN apk -Uuv add curl ca-certificates bash -RUN curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl -RUN chmod +x ./kubectl -RUN mv ./kubectl /usr/local/bin/kubectl -ADD update.sh /bin/ -RUN chmod +x /bin/update.sh -CMD bash -c /bin/update.sh +FROM alpine:3.4 +RUN apk --no-cache add curl ca-certificates bash +RUN curl -o /usr/local/bin/kubectl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl +RUN chmod +x /usr/local/bin/kubectl +COPY update.sh /bin/ +ENTRYPOINT ["/bin/bash"] +CMD ["/bin/update.sh"]